[PATCH] linux: fix ntp_gettime abi break

Kacper Piwiński vfjpl1@gmail.com
Wed Mar 8 08:58:29 GMT 2023


>From e7f73725d3a6de69fde1b24cdfb4e11df04db8fd Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Kacper=20Piwi=C5=84ski?= <vfjpl1@gmail.com>
Date: Wed, 8 Mar 2023 09:55:38 +0100
Subject: [PATCH] linux: fix ntp_gettime abi break

Resolves #30156.
---
 sysdeps/unix/sysv/linux/ntp_gettime.c | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/sysdeps/unix/sysv/linux/ntp_gettime.c
b/sysdeps/unix/sysv/linux/ntp_gettime.c
index 4879573530..af1ed920d3 100644
--- a/sysdeps/unix/sysv/linux/ntp_gettime.c
+++ b/sysdeps/unix/sysv/linux/ntp_gettime.c
@@ -26,6 +26,11 @@
 # define modes mode
 #endif

+/* glibc 2.12 added the 'tai' field to follow along the kernel, but it did
+   not add a compatibility symbol, instead it added __ntp_gettimex.  However
+   ntptimeval was still used in both cases, so to keep compatibility it
+   can not set all the new field.  */
+
 /* clock_adjtime64 with CLOCK_REALTIME does not trigger EINVAL,
    ENODEV, or EOPNOTSUPP.  It might still trigger EPERM.  */

@@ -40,7 +45,7 @@ __ntp_gettime64 (struct __ntptimeval64 *ntv)
   ntv->time = tntx.time;
   ntv->maxerror = tntx.maxerror;
   ntv->esterror = tntx.esterror;
-  ntv->tai = tntx.tai;
+
   return result;
 }

@@ -54,7 +59,9 @@ __ntp_gettime (struct ntptimeval *ntv)
   int result;

   result = __ntp_gettime64 (&ntv64);
-  *ntv = valid_ntptimeval64_to_ntptimeval (ntv64);
+  ntv->time = valid_timeval64_to_timeval (ntv64.time);
+  ntv->maxerror = ntv64.maxerror;
+  ntv->esterror = ntv64.esterror;

   return result;
 }
-- 
2.34.1


More information about the Libc-alpha mailing list