[PATCH] linux: fix ntp_gettime abi break

Adhemerval Zanella Netto adhemerval.zanella@linaro.org
Fri Mar 3 13:03:38 GMT 2023



On 03/03/23 05:47, Kacper Piwiński via Libc-alpha wrote:
> czw., 2 mar 2023 o 18:47 Carlos O'Donell <carlos@redhat.com> napisał(a):
>>
>> On 2/20/23 23:04, Kacper Piwiński via Libc-alpha wrote:
>>> Between versions v2.11 and v2.12 struct ntptimeval got new fields.
>>> That wasn't a problem because new function ntp_gettimex was created
>>> (and made default) to support new struct. Old ntp_gettime was not
>>> using new fields so it was safe to call with old struct
>>> definition. Then between versions v2.31 and v2.32 when working on
>>> y2038 bugs, ntp_gettime start setting new fields.
>>>
>>> Sets fields manually to maintain compatibility with v2.11 struct definition.
>>
>> The patch fails to apply.
>>
>> This fails pre-commit CI:
>> https://patchwork.sourceware.org/project/glibc/patch/CAKVti-BRav=mmfcQBEz_qpezmKfR_fFW9uihJb+QXiJazugTmA@mail.gmail.com/
>>
>> Please have a look at:
>> https://sourceware.org/glibc/wiki/Contribution%20checklist
>>
>> Did you generate the patch with `git format-patch`?
>>
> 
> Hi, yes I did but I didn't copy the whole thing. Anyway this patch is
> not correct. I attatched new patch here
> https://sourceware.org/bugzilla/show_bug.cgi?id=30156

Could you please resend as v2? Patch submission and discussion are done through
the maillist.

PS: maybe we should be more clear on wiki that patches are done discussed on
bugzilla.


More information about the Libc-alpha mailing list