[PATCH 04/21] sysdeps/{i386,x86_64}/mempcpy_chk.S: fix linknamespace for __mempcpy_chk
Siddhesh Poyarekar
siddhesh@gotplt.org
Thu Jun 22 04:02:53 GMT 2023
On 2023-06-21 13:26, Noah Goldstein wrote:
>>> diff --git a/sysdeps/x86_64/mempcpy_chk.S b/sysdeps/x86_64/mempcpy_chk.S
>>> index b1ddb02f78..b60ee4ff08 100644
>>> --- a/sysdeps/x86_64/mempcpy_chk.S
>>> +++ b/sysdeps/x86_64/mempcpy_chk.S
>>> @@ -28,6 +28,6 @@
>>> ENTRY (__mempcpy_chk)
>>> cmpq %rdx, %rcx
>>> jb __chk_fail
>>> - jmp mempcpy
>>> + jmp __mempcpy
>
> Does this get the right ifunc (or isa version isa version of built
> with cpu-specific flags)?
It should; __mempcpy is basically an internal alias for mempcpy, which
is an ifunc:
$ nm /lib64/libc.a | grep "i .*mempcpy"
0000000000000000 i __mempcpy
0000000000000000 i mempcpy
Sid
More information about the Libc-alpha
mailing list