[PATCH 1/4] aarch64: Add vector implementations of cos routines

Joe Ramsay joe.ramsay@arm.com
Thu Jun 15 14:43:15 GMT 2023


Hi Adhemerval, thanks for the comments.

On 13/06/2023 18:29, Adhemerval Zanella Netto wrote:

> It should not really matter for glibc, since we use -std=gnu11 and
> -fgnu89-inline, glibc does not really support building without optimization,
> and I think it is unlikely that these function will use anything that will
> prevent them to be inline (as indicated by gcc documentation [1] such as
> alloca); but for static inline used as macro we tend to use __always_inline.
> 
> And you seems to remove __always_inline from sve_utils.h.
> 
> [1] https://gcc.gnu.org/onlinedocs/gcc/Inline.html
>
static inline seems to be enough to ensure that these small functions 
are always inlined. We have done it this way to be consistent with 
existing scalar helper functions from both glibc and AOR, for example in 
various versions of math_config.h.

Cheers,
Joe


More information about the Libc-alpha mailing list