[PATCH v5] MIPS: Sync elf.h from binutils

[Maxim Kuvyrkov]

Thanks, Ying.

I've filed https://sourceware.org/bugzilla/show_bug.cgi?id=30554 to improve glibcpp.py.

Regards,

--
Maxim Kuvyrkov
https://www.linaro.org




> On Jun 15, 2023, at 11:06, Ying Huang <ying.huang@oss.cipunited.com> wrote:
> 
> Hi,
> 
> 在 2023/6/12 22:04, Maxim Kuvyrkov 写道:
>> Hi Ying,
>> 
>> I'm seeing test regressions [1] from this patch on aarch64-linux-gnu [2] and arm-linux-gnueabihf [3]:
>> ===
>> Running glibc:elf ...
>> FAIL: elf/tst-glibcelf 
>> FAIL: elf/tst-relro-ldso 
>> FAIL: elf/tst-relro-libc 
>> ===
>> Would you please investigate?  [Let me know if you need help in reproducing these failures.]
>> 
>> Which targets have you tested this patch on?
>> 
>> [1] https://patchwork.sourceware.org/project/glibc/patch/20230606061328.245050-1-ying.huang@oss.cipunited.com/
>> [2] https://ci.linaro.org/job/tcwg_glibc_check--master-aarch64-build/363/artifact/artifacts/artifacts.precommit/07-check_regression/results.compare/*view*/
>> [3] https://ci.linaro.org/job/tcwg_glibc_check--master-arm-build/327/artifact/artifacts/artifacts.precommit/07-check_regression/results.compare/*view*/
>> 
>> Kind regards,
>> 
>> --
>> Maxim Kuvyrkov
>> https://www.linaro.org
>> 
> Thanks for your test.
> 
> The error occurs when #define uses the continuation character '\'  and error message were:
> 
> cip@e150m12:~/glibc/build$ cat elf/tst-glibcelf.out
> /home/cip/glibc/scripts/../elf/elf.h:1708: error: uninterpretable macro token sequence: \
>  0x02000000
> Traceback (most recent call last):
>   File "/home/cip/glibc/elf/tst-glibcelf.py", line 23, in <module>
>     import glibcelf
>   File "/home/cip/glibc/scripts/glibcelf.py", line 226, in <module>
>     _elf_h = _parse_elf_h()
>   File "/home/cip/glibc/scripts/glibcelf.py", line 223, in _parse_elf_h
>     raise IOError('parse error in elf.h')
> OSError: parse error in elf.h
> 
> 
>>> +#define EF_MIPS_ARCH_ASE_MICROMIPS \
>>> + 0x02000000 /* Use MICROMIPS ISA
>>> +      extensions.  */
> 
> 
> This is the code.  And I found if I use non-parameters macro  with '\' woud report error.  If the macro has parameter woud be OK.  The file "glibc/scripts/glibcelf.py" has restrictions on this.
> 
> Thanks again and I would submit a new patch without '\'.
> 
> Ying