[PATCH 1/3] posix: Fix test-errno build with fortify enable
Adhemerval Zanella
adhemerval.zanella@linaro.org
Fri Jul 21 12:18:15 GMT 2023
With gcc 11.3.1, building with -D_FORTIFY_SOURCE=2 shows:
In function ‘getgroups’,
inlined from ‘do_test’ at test-errno.c:129:12:
../misc/sys/cdefs.h:195:6: error: argument 1 value -1 is negative
[-Werror=stringop-overflow=]
195 | ? __ ## f ## _alias (__VA_ARGS__)
\
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../posix/bits/unistd.h:115:10: note: in expansion of macro
‘__glibc_fortify’
115 | return __glibc_fortify (getgroups, __size, sizeof (__gid_t),
| ^~~~~~~~~~~~~~~
../posix/bits/unistd.h: In function ‘do_test’:
../posix/bits/unistd-decl.h:135:28: note: in a call to function
‘__getgroups_alias’ declared with attribute ‘access (write_only, 2, 1)’
135 | extern int __REDIRECT_NTH (__getgroups_alias, (int __size,
__gid_t __list[]),
| ^~~~~~~~~~~~~~~~~
../misc/sys/cdefs.h:264:6: note: in definition of macro ‘__REDIRECT_NTH’
264 | name proto __asm__ (__ASMNAME (#alias)) __THROW
It builds fine with gcc 12 and gcc 13.
Checked on x86_64-linux-gnu.
---
posix/test-errno.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/posix/test-errno.c b/posix/test-errno.c
index 305bc42938..3ef711bb41 100644
--- a/posix/test-errno.c
+++ b/posix/test-errno.c
@@ -17,6 +17,10 @@
License along with the GNU C Library; if not, see
<https://www.gnu.org/licenses/>. */
+#include <libc-diag.h>
+/* Triggered by getgroup fortify wrapper. */
+DIAG_IGNORE_NEEDS_COMMENT (6, "-Wstringop-overflow");
+
#include <errno.h>
#include <limits.h>
#include <grp.h>
@@ -34,7 +38,6 @@
#include <sys/uio.h>
#include <unistd.h>
#include <netinet/in.h>
-#include <libc-diag.h>
/* This is not an exhaustive test: only system calls that can be
persuaded to fail with a consistent error code and no side effects
--
2.34.1
More information about the Libc-alpha
mailing list