[PATCH] Account for octal marker in %#o format
Carlos O'Donell
carlos@redhat.com
Mon Jan 30 14:43:48 GMT 2023
On 1/30/23 06:11, Florian Weimer wrote:
> * Andreas Schwab via Libc-alpha:
>
>> @@ -257,6 +260,9 @@ LABEL (unsigned_number): /* Unsigned number of base BASE. */
>> width -= 2;
>> }
>>
>> + if (octal_marker)
>> + --width;
>> +
>> width -= number_length + prec;
>
> This doesn't apply because master still has
>
> width -= workend - string + prec;
>
> Apart from that, the change looks okay.
>
> Carlos, this would be a regression, so I think we should fix it before
> the release.
Agreed. We should fix this ASAP for the 2.37 release.
Andreas, Thanks for putting together a fix. I'm reviewing this now.
--
Cheers,
Carlos.
More information about the Libc-alpha
mailing list