[PATCH v2 3/3] scripts/build-many-glibcs.py: Remove unused RANLIB and STRIP option

Carlos O'Donell carlos@redhat.com
Wed Jan 11 20:28:57 GMT 2023


On 12/6/22 11:02, Adhemerval Zanella wrote:

LGTM.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>

> ---
>  scripts/build-many-glibcs.py | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/scripts/build-many-glibcs.py b/scripts/build-many-glibcs.py
> index a49f50b792..32f336366c 100755
> --- a/scripts/build-many-glibcs.py
> +++ b/scripts/build-many-glibcs.py
> @@ -1521,8 +1521,6 @@ class GlibcPolicyDefault(object):
>              '--host=%s' % glibc.triplet,
>              'CC=%s' % glibc.tool_name('gcc'),
>              'CXX=%s' % glibc.tool_name('g++'),
> -            'RANLIB=%s' % glibc.tool_name('ranlib'),
> -            'STRIP=%s' % glibc.tool_name('strip'),

OK. Agreed, these aren't used and we should make this as concise as possible.

>          ]
>          if glibc.os == 'gnu':
>              self.configure_args.append('MIG=%s' % glibc.tool_name('mig'))

-- 
Cheers,
Carlos.



More information about the Libc-alpha mailing list