[PATCH] crypt: Remove invalid end of page test badsalttest

Wilco Dijkstra Wilco.Dijkstra@arm.com
Mon Feb 27 13:29:20 GMT 2023


Hi Adhemerval,

> The input argument passes an invalid string with a NULL terminator

*without* a NUL terminator

> on crypt settings inputs, which might lead to invalid OOB on strncmp
> (where multiple implementation assumes that the input is always a
> NULL terminated string).

Implementations only assume there is a NUL terminator if the string is shorter
than the specified size, so strings don't need to always be NUL terminated
(stratcliff.c has tests for this).

Cheers,
Wilco


More information about the Libc-alpha mailing list