[PATCH] hppa: Drop old parisc-specific MADV_* constants

Helge Deller deller@gmx.de
Fri Feb 10 10:48:50 GMT 2023


On 2/10/23 11:18, Florian Weimer wrote:
> * Helge Deller via Libc-alpha:
>
>> The Linux kernel upstream commit 71bdea6f798b ("parisc: Align parisc
>> MADV_XXX constants with all other architectures") dropped the
>> parisc-specific MADV_* values in favour of the same constants as
>> other architectures. In the same commit a wrapper was added which
>> translates the old values to the standard MADV_* values to avoid
>> breakage of existing programs.
>> This upstream patch has been downported to all stable kernel trees as
>> well.
>
> What about qemu-user?  Maybe it has always worked?

qemu-user was broken before, which is why I noticed that difference at all,
and which is the reason I came up with the kernel patch.
I did sent a fix for qemu-user too, which was applied some days ago:
https://gitlab.com/qemu-project/qemu/-/commit/4530deb1fe81152ae2384a56eb7edb5467f894fa

>> This patch now drops the parisc specific constants from glibc to
>> allow newly compliled programs to use the standard MADV_* constants.
>
> I appreciate the simplification, but I think this needs a NEWS file
> update, spelling out the required kernel versions on hppa if the madvise
> function is used.

Maybe add to the "Deprecated and removed features, and other changes affecting compatibility:"
section something like this?

* In the Linux kernel for the hppa/parisc architecture some of the MADV_ constants
   were changed to have the same values as the other architectures.
   New programs compiled with this glibc version and which use the madvise() call will
   require at least Linux kernels version 6.2, alternatively stable kernels
   from version 6.1.6, version 5.15.87 or version 5.10.163.

Helge


More information about the Libc-alpha mailing list