[PATCH] configure: Add -Wall again to the default CFLAGS

Siddhesh Poyarekar siddhesh@gotplt.org
Mon Aug 14 12:10:10 GMT 2023


On 2023-08-14 07:49, Florian Weimer via Libc-alpha wrote:
> Commit 78ceef25d64efeeb6067d1cb282a00466e637e2a ("configure: Remove
> --enable-all-warnings option") removed it due to a missing +.
> 
> Tested with build-many-glibcs.py (glibcs stage only, full
> compilers/glibcs test still running).  Needs -Wall fixes from the recent
> malloc fix.
> 
> ---
>   Makeconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

LGTM.

Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>

> 
> diff --git a/Makeconfig b/Makeconfig
> index c4dd9ea8f2..c48fcc59e8 100644
> --- a/Makeconfig
> +++ b/Makeconfig
> @@ -857,7 +857,7 @@ host-test-program-cmd = $(host-built-program-cmd)
>   endif
>   
>   # Extra flags to pass to GCC.
> -gccwarn := -Wall -Wwrite-strings -Wundef
> ++gccwarn := -Wall -Wwrite-strings -Wundef
>   ifeq ($(enable-werror),yes)
>   +gccwarn += -Werror
>   endif
> 
> base-commit: bb481eedcee19bb342b91eddc86417df660e6c56
> 


More information about the Libc-alpha mailing list