[PATCH v2] x86: Fix incorrect scope of setting `shared_per_thread` [BZ# 30745]

Noah Goldstein goldstein.w.n@gmail.com
Fri Aug 11 17:29:24 GMT 2023


On Fri, Aug 11, 2023 at 2:46 AM Andreas Schwab <schwab@linux-m68k.org> wrote:
>
> On Aug 10 2023, Noah Goldstein via Libc-alpha wrote:
>
> > diff --git a/sysdeps/x86/dl-cacheinfo.h b/sysdeps/x86/dl-cacheinfo.h
> > index 285773039f..88316a7818 100644
> > --- a/sysdeps/x86/dl-cacheinfo.h
> > +++ b/sysdeps/x86/dl-cacheinfo.h
> > @@ -770,11 +770,10 @@ get_common_cache_info (long int *shared_ptr, long int * shared_per_thread_ptr, u
> >            level.  */
> >         threads = ((cpu_features->features[CPUID_INDEX_1].cpuid.ebx >> 16)
> >                    & 0xff);
> > -
> > +        }
> >         /* Get per-thread size of highest level cache.  */
> >         if (shared_per_thread > 0 && threads > 0)
> >           shared_per_thread /= threads;
> > -     }
>
> Please fix the indentation.
>

Done.
> --
> Andreas Schwab, schwab@linux-m68k.org
> GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
> "And now for something completely different."


More information about the Libc-alpha mailing list