[PATCH v7 3/8] linux: Undef __ASSUME_CLONE3 for alpha, ia64, nios2, sh, and sparc

Florian Weimer fweimer@redhat.com
Fri Aug 11 10:34:33 GMT 2023


* Adhemerval Zanella via Libc-alpha:

> Not all architectures added clone3 syscall.
> ---
>  .../unix/sysv/linux/alpha/kernel-features.h   |  3 +++
>  .../unix/sysv/linux/ia64/kernel-features.h    |  3 +++
>  .../unix/sysv/linux/nios2/kernel-features.h   | 23 +++++++++++++++++++
>  sysdeps/unix/sysv/linux/sh/kernel-features.h  |  3 +++
>  .../unix/sysv/linux/sparc/kernel-features.h   |  3 +++
>  5 files changed, 35 insertions(+)
>  create mode 100644 sysdeps/unix/sysv/linux/nios2/kernel-features.h
>
> diff --git a/sysdeps/unix/sysv/linux/alpha/kernel-features.h b/sysdeps/unix/sysv/linux/alpha/kernel-features.h
> index 3151e75449..e298bf2bcc 100644
> --- a/sysdeps/unix/sysv/linux/alpha/kernel-features.h
> +++ b/sysdeps/unix/sysv/linux/alpha/kernel-features.h
> @@ -50,4 +50,7 @@
>  /* Alpha requires old sysvipc even being a 64-bit architecture.  */
>  #undef __ASSUME_SYSVIPC_DEFAULT_IPC_64
>  
> +/* Alpha does not provide clone3.  */
> +#undef __ASSUME_CLONE3

This is inconsistent with sysdeps/unix/sysv/linux/kernel-features.h,
which I think uses 0 to indicate no support:

/* The clone3 system call was introduced across on most architectures in
   Linux 5.3.  Not all ports implements it, so it should be used along
   HAVE_CLONE3_WRAPPER define.  */
#if __LINUX_KERNEL_VERSION >= 0x050300
# define __ASSUME_CLONE3 1
#else
# define __ASSUME_CLONE3 0

Maybe that comment needs updating in this series, too?

Thanks,
Florian



More information about the Libc-alpha mailing list