Run TryBot-apply_patch on the full queue?

Carlos O'Donell carlos@redhat.com
Tue Sep 20 10:21:17 GMT 2022


On Mon, Sep 19, 2022 at 03:55:51PM -0400, DJ Delorie wrote:
> "Carlos O'Donell" <carlos@redhat.com> writes:
> > The curator/runners are a more advanced "patchwork bot" framework that
> > can do very specific things.
> 
> I think it might be wise to keep the trybot API the same, though.  I
> mean, if we have a "patch applies" trybot, it can be controlled by the
> current curator (once per patch seen) as well as by a patchwork bot that
> retries all patches once a day.

That makes sense.

My only concern had been "how do you authenticate this?"

However, after having slept a full night I realized that we need signed
emails, so the curator already needs to validate signatures.

The "injection" API could take signed messages too?

> Both systems just need to inject the right json into the trybot's queue,
> and that information comes mainly from patchwork anyway.

Right.

> The "do once per patch" case is still common (and important) enough to
> warrant a centralized curator though.

Yes. We should just accept a "signed message" API?

That would reuse all the same infrastructure we have for signed emails?

c.



More information about the Libc-alpha mailing list