[PATCH] stdio-common: Add missing dependencies (bug 29780)

Florian Weimer fweimer@redhat.com
Mon Nov 21 16:06:01 GMT 2022


* Andreas Schwab via Libc-alpha:

> Handle all object suffixes for dependencies of errlist-data and siglist
> objects.
> ---
>  stdio-common/Makefile | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/stdio-common/Makefile b/stdio-common/Makefile
> index 401dac69de..fe57dbdf56 100644
> --- a/stdio-common/Makefile
> +++ b/stdio-common/Makefile
> @@ -272,7 +272,8 @@ ifndef no_deps
>  endif
>  
>  $(objpfx)errlist-data.os: $(objpfx)errlist-data-aux-shared.S
> -$(objpfx)errlist-data.o: $(objpfx)errlist-data-aux.S
> +$(addprefix $(objpfx)errlist-data, $(object-suffixes-noshared)): \
> +  $(objpfx)errlist-data-aux.S
>  
>  $(objpfx)siglist-aux-shared.S: siglist-gen.c
>  	$(make-target-directory)
> @@ -287,7 +288,8 @@ ifndef no_deps
>  endif
>  
>  $(objpfx)siglist.os: $(objpfx)siglist-aux-shared.S
> -$(objpfx)siglist.o: $(objpfx)siglist-aux.S
> +$(addprefix $(objpfx)siglist, $(object-suffixes-noshared)): \
> +  $(objpfx)siglist-aux.S
>  
>  ifeq ($(run-built-tests),yes)
>  LOCALES := \

Looks okay, thanks.

Reviewed-by: Florian Weimer <fweimer@redhat.com>

Florian



More information about the Libc-alpha mailing list