[PATCH] [locale] Corrected return value check.
Dmitry Chestnyh
d.chestnyh@omp.ru
Thu Mar 31 19:37:01 GMT 2022
strtol returns LONG_MAX or LONG_MIN on
ERANGE error.
This issue was found by SVACE static analyzer.
---
locale/programs/ld-collate.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/locale/programs/ld-collate.c b/locale/programs/ld-collate.c
index 992814491d..751435a900 100644
--- a/locale/programs/ld-collate.c
+++ b/locale/programs/ld-collate.c
@@ -1344,12 +1344,12 @@ order for `%.*s' already defined at %s:%Zu"),
errno = 0;
from = strtol (startp->name + preflen, &cp, base);
- if ((from == UINT_MAX && errno == ERANGE) || *cp != '\0')
+ if (((from == LONG_MAX || from == LONG_MIN ) && errno == ERANGE) || *cp != '\0')
goto invalid_range;
errno = 0;
to = strtol (endp->name + preflen, &cp, base);
- if ((to == UINT_MAX && errno == ERANGE) || *cp != '\0')
+ if (((to == LONG_MAX || to == LONG_MIN ) && errno == ERANGE) || *cp != '\0')
goto invalid_range;
/* Copy the prefix. */
--
2.25.1
More information about the Libc-alpha
mailing list