[PATCH v2 11/12] gaih_inet: Split result generation into its own function

Siddhesh Poyarekar siddhesh@sourceware.org
Thu Mar 17 05:11:23 GMT 2022


On 17/03/2022 10:35, DJ Delorie wrote:
> Siddhesh Poyarekar via Libc-alpha <libc-alpha@sourceware.org> writes:
>> Simplify the loop a wee bit and clean up variable names too.
> 
> FYI combining "split out" and "minor changes" makes it harder to review,
> because the minor changes are nearly impossible to spot in the large
> chunks of "moving".

Ack, I got a bit lazy :/

> I had one comment about a leak (see below) but it's independent of this
> patch set (maybe?).

Yeah, it's a preexisting leak, but it only manifests when the system is 
out of memory.

Thanks,
Siddhesh


More information about the Libc-alpha mailing list