[PATCH] benchtests: Use "=" instead of ":=" [BZ #28970]

Sunil Pandey skpgkp2@gmail.com
Wed Mar 16 15:46:19 GMT 2022


On Wed, Mar 16, 2022 at 8:44 AM H.J. Lu via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>
> Use "=" instead of ":=" to allow sysdeps Makefiles to add more benches
> to bench and benchset.  This fixes BZ #28970.
> ---
>  benchtests/Makefile | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/benchtests/Makefile b/benchtests/Makefile
> index d513b29903..8dfca592fd 100644
> --- a/benchtests/Makefile
> +++ b/benchtests/Makefile
> @@ -296,9 +296,11 @@ bench-extra-objs = json-lib.o
>  extra-objs += $(bench-extra-objs)
>  others-extras = $(bench-extra-objs)
>
> -binaries-bench := $(addprefix $(objpfx)bench-,$(bench))
> +# NB: Use "=" instead of ":=" since sysdeps Makefiles may add more
> +# benches.
> +binaries-bench = $(addprefix $(objpfx)bench-,$(bench))
>  extra-objs += $(addsuffix .o,$(addprefix bench-,$(bench)))
> -binaries-benchset := $(addprefix $(objpfx)bench-,$(benchset))
> +binaries-benchset = $(addprefix $(objpfx)bench-,$(benchset))
>  extra-objs += $(addsuffix .o,$(addprefix bench-,$(benchset)))
>  binaries-bench-malloc := $(addprefix $(objpfx)bench-,$(bench-malloc))
>  extra-objs += $(addsuffix .o,$(addprefix bench-,$(bench-malloc)))
> --
> 2.35.1
>

LGTM

Reviewed-by: Sunil K Pandey <skpgkp2@gmail.com>


More information about the Libc-alpha mailing list