[PATCH 01/12] Simplify allocations and fix merge and continue actions [BZ #28931]
Siddhesh Poyarekar
siddhesh@gotplt.org
Wed Mar 9 17:13:16 GMT 2022
[Sorry, I thought I responded to this, but I clearly didn't]
On 09/03/2022 02:42, Carlos O'Donell wrote:
> No new tests should rely on external DNS being available during testing.
>
> The trybots must be able to run disconnected and fully isolated from the network
> from an operational security perspective.
>
> You can and should provide either a stub NSS resolver that returns results for DNS
> that just feeds that data back to you.
>
> This is an indication of an incomplete test, in that we need to be able to control
> all inputs to the test, otherwise this test is unreliable at best and will spurious
> fail when DNS goes down.
I'll just drop the dns tests. I had put it in there because "dns
[SUCCESS=continue] dns" would segfault in nss_dns, but that's only a
symptom of the problem in gaih_inet. The remaining nss_files tests in
tst-nss-gai-actions.c test that core problem, so we have the coverage we
need.
Thanks,
Siddhesh
More information about the Libc-alpha
mailing list