[PATCH] scripts/dso-ordering-test.py: Fix C&P error in * callrefs processing

Florian Weimer fweimer@redhat.com
Wed Mar 9 10:24:16 GMT 2022


The elf/dso-sort-tests-src subdirectory is not changed by this commit,
so it seems that the cut-and-paste error was not material.

This was reported by some downstream static analysis tool.

---
 scripts/dso-ordering-test.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/scripts/dso-ordering-test.py b/scripts/dso-ordering-test.py
index 0b526aff45..2dd6bfda18 100644
--- a/scripts/dso-ordering-test.py
+++ b/scripts/dso-ordering-test.py
@@ -551,17 +551,17 @@ def process_testcase(t):
         if obj in t.deps:
             deps = t.deps[obj]
             if '*' in deps:
-                t.deps[obj].remove('*')
+                deps.remove('*')
                 t.add_deps([obj], non_dep_tgt_objs)
         if obj in t.callrefs:
             deps = t.callrefs[obj]
             if '*' in deps:
-                t.deps[obj].remove('*')
+                deps.remove('*')
                 t.add_callrefs([obj], non_dep_tgt_objs)
     if "#" in t.deps:
         deps = t.deps["#"]
         if '*' in deps:
-            t.deps["#"].remove('*')
+            deps.remove('*')
             t.add_deps(["#"], non_dep_tgt_objs)
 
     # If no main program was specified in dependency description, make a



More information about the Libc-alpha mailing list