[PATCH 001/126] x86_64: Fix svml_s_acosf16_core_avx512.S code formatting

[Noah Goldstein]

On Mon, Mar 7, 2022 at 3:51 PM Sunil Pandey <skpgkp2@gmail.com> wrote:
>
> On Mon, Mar 7, 2022 at 7:25 AM Sunil K Pandey via Libc-alpha
> <libc-alpha@sourceware.org> wrote:
> >
> > This commit contains following formatting changes
> >
> > 1. Instructions proceeded by a tab.
> > 2. Instruction less than 8 characters in length have a tab
> >    between it and the first operand.
> > 3. Instruction greater than 7 characters in length have a
> >    space between it and the first operand.
> > 4. Tabs after `#define`d names and their value.
> > 5. 8 space at the beginning of line replaced by tab.
> > 6. Indent comments with code.
> > 7. Remove redundent .text section.
>
> Following are revised commit message
>
>     This commit contains following formatting changes
>
>     1. Instructions proceeded by a tab.
>     2. Instruction less than 8 characters in length have a tab
>        between it and the first operand.
>     3. Instruction greater than 7 characters in length have a
>        space between it and the first operand.
>     4. Tabs after `#define`d names and their value.
>     5. 8 space at the beginning of line replaced by tab.
>     6. Indent comments with code.
>     7. Remove redundent .text section.
>     8. 1 space between line content and line comment.
>     9. Space after all commas.
>
> All other patches have the same commit message.
>
>
> > ---
> >  .../multiarch/svml_s_acosf16_core_avx512.S    | 28 +++++++++----------
> >  1 file changed, 14 insertions(+), 14 deletions(-)
> >
> > diff --git a/sysdeps/x86_64/fpu/multiarch/svml_s_acosf16_core_avx512.S b/sysdeps/x86_64/fpu/multiarch/svml_s_acosf16_core_avx512.S
> > index f08d4304fa..26fef1f268 100644
> > --- a/sysdeps/x86_64/fpu/multiarch/svml_s_acosf16_core_avx512.S
> > +++ b/sysdeps/x86_64/fpu/multiarch/svml_s_acosf16_core_avx512.S
> > @@ -46,7 +46,7 @@
> >
> >  #include <sysdep.h>
> >
> > -       .section .text.exex512,"ax",@progbits
> > +       .section .text.exex512, "ax", @progbits
> >  ENTRY(_ZGVeN16v_acosf_skx)
> >         pushq   %rbp
> >         cfi_def_cfa_offset(16)
> > @@ -205,11 +205,11 @@ L(SPECIAL_VALUES_LOOP):
> >
> >  L(SCALAR_MATH_CALL):
> >         movl    %r12d, %r14d
> > -       movss   64(%rsp,%r14,4), %xmm0
> > +       movss   64(%rsp, %r14, 4), %xmm0
> >         call    acosf@PLT
> >         # LOE rbx r14 r15 r12d r13d xmm0
> >
> > -       movss   %xmm0, 128(%rsp,%r14,4)
> > +       movss   %xmm0, 128(%rsp, %r14, 4)
> >
> >         /* Process special inputs in loop */
> >         jmp     L(SPECIAL_VALUES_LOOP)
> > @@ -234,37 +234,37 @@ typedef struct {
> >  } __svml_sacos_data_internal;
> >  #endif
> >  __svml_sacos_data_internal:
> > -       /*== SgnBit ==*/
> > +       /* SgnBit */
> >         .long   0x80000000, 0x80000000, 0x80000000, 0x80000000, 0x80000000, 0x80000000, 0x80000000, 0x80000000, 0x80000000, 0x80000000, 0x80000000, 0x80000000, 0x80000000, 0x80000000, 0x80000000, 0x80000000
> > -       /*== OneHalf ==*/
> > +       /* OneHalf */
> >         .align  64
> >         .long   0x3f000000, 0x3f000000, 0x3f000000, 0x3f000000, 0x3f000000, 0x3f000000, 0x3f000000, 0x3f000000, 0x3f000000, 0x3f000000, 0x3f000000, 0x3f000000, 0x3f000000, 0x3f000000, 0x3f000000, 0x3f000000
> > -       /*== SmallNorm ==*/
> > +       /* SmallNorm */
> >         .align  64
> >         .long   0x2f800000, 0x2f800000, 0x2f800000, 0x2f800000, 0x2f800000, 0x2f800000, 0x2f800000, 0x2f800000, 0x2f800000, 0x2f800000, 0x2f800000, 0x2f800000, 0x2f800000, 0x2f800000, 0x2f800000, 0x2f800000
> > -       /*== MOne ==*/
> > +       /* MOne */
> >         .align  64
> >         .long   0xbf800000, 0xbf800000, 0xbf800000, 0xbf800000, 0xbf800000, 0xbf800000, 0xbf800000, 0xbf800000, 0xbf800000, 0xbf800000, 0xbf800000, 0xbf800000, 0xbf800000, 0xbf800000, 0xbf800000, 0xbf800000
> > -       /*== Two ==*/
> > +       /* Two */
> >         .align  64
> >         .long   0x40000000, 0x40000000, 0x40000000, 0x40000000, 0x40000000, 0x40000000, 0x40000000, 0x40000000, 0x40000000, 0x40000000, 0x40000000, 0x40000000, 0x40000000, 0x40000000, 0x40000000, 0x40000000
> > -       /*== sqrt_coeff[2] ==*/
> > +       /* sqrt_coeff[2] */
> >         .align  64
> >         .long   0xbdC00004, 0xbdC00004, 0xbdC00004, 0xbdC00004, 0xbdC00004, 0xbdC00004, 0xbdC00004, 0xbdC00004, 0xbdC00004, 0xbdC00004, 0xbdC00004, 0xbdC00004, 0xbdC00004, 0xbdC00004, 0xbdC00004, 0xbdC00004 /* sqrt_coeff2 */
> >         .long   0x3e800001, 0x3e800001, 0x3e800001, 0x3e800001, 0x3e800001, 0x3e800001, 0x3e800001, 0x3e800001, 0x3e800001, 0x3e800001, 0x3e800001, 0x3e800001, 0x3e800001, 0x3e800001, 0x3e800001, 0x3e800001 /* sqrt_coeff1 */
> > -       /*== poly_coeff[5] ==*/
> > +       /* poly_coeff[5] */
> >         .align  64
> >         .long   0x3d2EDC07, 0x3d2EDC07, 0x3d2EDC07, 0x3d2EDC07, 0x3d2EDC07, 0x3d2EDC07, 0x3d2EDC07, 0x3d2EDC07, 0x3d2EDC07, 0x3d2EDC07, 0x3d2EDC07, 0x3d2EDC07, 0x3d2EDC07, 0x3d2EDC07, 0x3d2EDC07, 0x3d2EDC07 /* poly_coeff5 */
> >         .long   0x3CC32A6B, 0x3CC32A6B, 0x3CC32A6B, 0x3CC32A6B, 0x3CC32A6B, 0x3CC32A6B, 0x3CC32A6B, 0x3CC32A6B, 0x3CC32A6B, 0x3CC32A6B, 0x3CC32A6B, 0x3CC32A6B, 0x3CC32A6B, 0x3CC32A6B, 0x3CC32A6B, 0x3CC32A6B /* poly_coeff4 */
> >         .long   0x3d3A9AB4, 0x3d3A9AB4, 0x3d3A9AB4, 0x3d3A9AB4, 0x3d3A9AB4, 0x3d3A9AB4, 0x3d3A9AB4, 0x3d3A9AB4, 0x3d3A9AB4, 0x3d3A9AB4, 0x3d3A9AB4, 0x3d3A9AB4, 0x3d3A9AB4, 0x3d3A9AB4, 0x3d3A9AB4, 0x3d3A9AB4 /* poly_coeff3 */
> >         .long   0x3d997C12, 0x3d997C12, 0x3d997C12, 0x3d997C12, 0x3d997C12, 0x3d997C12, 0x3d997C12, 0x3d997C12, 0x3d997C12, 0x3d997C12, 0x3d997C12, 0x3d997C12, 0x3d997C12, 0x3d997C12, 0x3d997C12, 0x3d997C12 /* poly_coeff2 */
> >         .long   0x3e2AAAFF, 0x3e2AAAFF, 0x3e2AAAFF, 0x3e2AAAFF, 0x3e2AAAFF, 0x3e2AAAFF, 0x3e2AAAFF, 0x3e2AAAFF, 0x3e2AAAFF, 0x3e2AAAFF, 0x3e2AAAFF, 0x3e2AAAFF, 0x3e2AAAFF, 0x3e2AAAFF, 0x3e2AAAFF, 0x3e2AAAFF /* poly_coeff1 */
> > -       /*== Pi2H ==*/
> > +       /* Pi2H */
> >         .align  64
> >         .long   0x3fc90FDB, 0x3fc90FDB, 0x3fc90FDB, 0x3fc90FDB, 0x3fc90FDB, 0x3fc90FDB, 0x3fc90FDB, 0x3fc90FDB, 0x3fc90FDB, 0x3fc90FDB, 0x3fc90FDB, 0x3fc90FDB, 0x3fc90FDB, 0x3fc90FDB, 0x3fc90FDB, 0x3fc90FDB
> > -       /*== PiH ==*/
> > +       /* PiH */
> >         .align  64
> >         .long   0x40490FDB, 0x40490FDB, 0x40490FDB, 0x40490FDB, 0x40490FDB, 0x40490FDB, 0x40490FDB, 0x40490FDB, 0x40490FDB, 0x40490FDB, 0x40490FDB, 0x40490FDB, 0x40490FDB, 0x40490FDB, 0x40490FDB, 0x40490FDB
> >         .align  64
> > -       .type   __svml_sacos_data_internal,@object
> > -       .size   __svml_sacos_data_internal,.-__svml_sacos_data_internal
> > +       .type   __svml_sacos_data_internal, @object
> > +       .size   __svml_sacos_data_internal, .-__svml_sacos_data_internal
> > --
> > 2.34.1
> >
>
> Is this patch with revised commit message is OK?

Yes.
> Same question for rest of the patches in this patch set?

LGTM. Verified that there is difference in the generated assembly between any
of the files before/after formatting.