[PATCH 2/2] Remove dl-librecon.h header.

Adhemerval Zanella adhemerval.zanella@linaro.org
Fri Mar 4 12:42:53 GMT 2022



On 28/02/2022 16:11, Florian Weimer wrote:
> * Adhemerval Zanella via Libc-alpha:
> 
>> diff --git a/elf/dl-support.c b/elf/dl-support.c
>> index 1d648ce3a6..fa9fcdbe5a 100644
>> --- a/elf/dl-support.c
>> +++ b/elf/dl-support.c
> 
>> @@ -370,15 +367,9 @@ _dl_non_dynamic_init (void)
>>  
>>    if (__libc_enable_secure)
>>      {
>> -      static const char unsecure_envvars[] =
>> -	UNSECURE_ENVVARS
>> -#ifdef EXTRA_UNSECURE_ENVVARS
>> -	EXTRA_UNSECURE_ENVVARS
>> -#endif
>> -	;
>> -      const char *cp = unsecure_envvars;
>> +      const char *cp = UNSECURE_ENVVARS;
>>  
>> -      while (cp < unsecure_envvars + sizeof (unsecure_envvars))
>> +      while (cp < UNSECURE_ENVVARS + sizeof (UNSECURE_ENVVARS))
>>  	{
>>  	  __unsetenv (cp);
>>  	  cp = (const char *) __rawmemchr (cp, '\0') + 1;
> 
> Please keep unsecure_envvars.  I think C does not guarantee that there
> is just one array for UNSECURE_ENVVARS.
> 

Ack.

> Rest looks okay to me.
> 



More information about the Libc-alpha mailing list