[PATCH v7 6/9] x86: Add AVX2 optimized chacha20

Adhemerval Zanella adhemerval.zanella@linaro.org
Wed Jun 29 20:59:07 GMT 2022



> On 29 Jun 2022, at 13:41, Noah Goldstein <goldstein.w.n@gmail.com> wrote:
> 
> 
>> +       /* clear the used vector registers and stack */
>> +       vpxor X0, X0, X0;
>> +       vmovdqa X0, (STACK_VEC_X12)(%rsp);
>> +       vmovdqa X0, (STACK_VEC_X13)(%rsp);
>> +       vmovdqa X0, (STACK_TMP)(%rsp);
>> +       vmovdqa X0, (STACK_TMP1)(%rsp);
>> +       vzeroall;
> 
> I thought the state clearing wasn't necessary because
> this wasn't meant to be "secure".
> 
> Somewhat in favor of removing this just so it doesn't
> become something we have to support in the future.

Alright, I think it makes sense. I will adjust all optimized routines and
resent it.




More information about the Libc-alpha mailing list