[PATCH v6 02/10] stdlib: Add arc4random tests
Florian Weimer
fweimer@redhat.com
Tue Jun 28 11:59:03 GMT 2022
* Adhemerval Zanella:
> diff --git a/stdlib/tst-arc4random-chacha20.c b/stdlib/tst-arc4random-chacha20.c
> new file mode 100644
> index 0000000000..dd0ef6d8ba
> --- /dev/null
> +++ b/stdlib/tst-arc4random-chacha20.c
> @@ -0,0 +1,166 @@
> + <http://www.gnu.org/licenses/>. */
https://, not http://. This impacts the other new files.
> +#include <support/check.h>
> +#include <sys/cdefs.h>
> +
> +/* It does not define CHACHA20_XOR_FINAL to check what glibc actual uses. */
Please rephrase what is ”it” in this context? Missing space after ”.”.
> + /* Check with the expected internal arc4random keystream buffer. Some
> + architecture optimization expectes a buffer with a minimum size of
> + multiple of ChaCha20 blocksize, so they might not be prepared to
> + handle smaller buffers. */
“a minimum size which is a multiple of the ChaCha20 block size”?
Thanks,
Florian
More information about the Libc-alpha
mailing list