[PATCH 1/4] time/tst-clock2.c: clock_settime CLOCK_MONOTONIC might return EPERM

Mark Wielaard mark@klomp.org
Mon Jun 27 09:35:07 GMT 2022


Hi Florian,

On Sun, 2022-06-26 at 23:15 +0200, Florian Weimer wrote:
> * Mark Wielaard:
> > -      printf ("clock_settime(CLOCK_MONOTONIC) set errno to %d,
> > expected %d\n",
> > -	      errno, EINVAL);
> > +      printf ("clock_settime(CLOCK_MONOTONIC) set errno to %d,
> > expected %d or %d\n",
> > +	      errno, EINVAL, EPERM);
> >        return 1;
> >      }
> >    return 0;
> 
> You could use "errno to %d (%#m)" if you are changing this line
> anyway.
> And isn't the line too long?
> 
> Direction looks okay to me.

Yes, the line is too long. Sorry, my terminal window was too wide. Will
fix and add (%#m) in v2.

Thanks,

Mark


More information about the Libc-alpha mailing list