[PATCH v5 2/8] linux: Add fsmount

[Adhemerval Zanella]

On 07/06/2022 13:14, Yann Droneaud wrote:

>> diff --git a/NEWS b/NEWS
>> index a94e8c0124..51ca68f1da 100644
>> --- a/NEWS
>> +++ b/NEWS
>> @@ -29,8 +29,8 @@ Major new features:
>>     memory is carried out in the context of the caller, using the caller's
>>     CPU affinity, and priority with CPU usage accounted to the caller.
>>   -* On Linux, the fsopen has been added.  It is a new mount API to allow
>> -  more flexibility on mount operations, specially when used along
>> +* On Linux, the fsopen and fsmound have been added.  It is a new mount API
> 
> fsopen and fsmount
> 

Fixed, thanks.

>>     __BEGIN_DECLS
>>   @@ -155,6 +171,11 @@ extern int umount2 (const char *__special_file, int __flags) __THROW;
>>      mouting.  */
>>   extern int fsopen (const char *__fs_name, unsigned int __flags) __THROW;
>>   +/* Create a mount representation for the FD created by fsopen using
>> +   FLAGS with ATTR_FLAGS describing who the mount is to be performed.  */
> 
> 
> describing how the mount
> 

Ack.

> 
>> +extern int fsmount (int __fd, unsigned int __flags,
>> +            unsigned int __ms_flags) __THROW;
>> +
>>   __END_DECLS
>>     #endif /* _SYS_MOUNT_H */
>> diff --git a/sysdeps/unix/sysv/linux/syscalls.list b/sysdeps/unix/sysv/linux/syscalls.list
>> index a2919f433d..4ac6fe7659 100644
>> --- a/sysdeps/unix/sysv/linux/syscalls.list
>> +++ b/sysdeps/unix/sysv/linux/syscalls.list
>> @@ -12,6 +12,7 @@ epoll_ctl    EXTRA    epoll_ctl    i:iiip    epoll_ctl
>>   eventfd        EXTRA    eventfd2    i:ii    eventfd
>>   execve        -    execve        i:spp    __execve    execve
>>   flock        -    flock        i:ii    __flock        flock
>> +fsmount        EXTRA    fsmount        i:iUU    fsmount
>>   fsopen        EXTRA    fsopen        i:sU    fsopen
>>   get_kernel_syms    EXTRA    get_kernel_syms    i:p    __compat_get_kernel_syms    get_kernel_syms@GLIBC_2.0:GLIBC_2.23
>>   getpid          -       getpid          Ei:     __getpid        getpid
>> diff --git a/sysdeps/unix/sysv/linux/tst-mount-consts.py b/sysdeps/unix/sysv/linux/tst-mount-consts.py
>> index 162b01147d..4d4a234f3a 100755
>> --- a/sysdeps/unix/sysv/linux/tst-mount-consts.py
>> +++ b/sysdeps/unix/sysv/linux/tst-mount-consts.py
>> @@ -46,7 +46,11 @@ def main():
>>                   linux_version_glibc > linux_version_headers,
>>                   linux_version_headers > linux_version_glibc)
>>   -    status = check('FSOPEN_.*')
>> +    status = max(
>> +        check('FSOPEN_.*'),
>> +        check('FSMOUNT_.*'),
>> +        # MOUNT_ATTR_SIZE_VER0 is used for mount_setattr.
>> +        check('MOUNT_ATTR_.*', 'MOUNT_ATTR_SIZE_VER0'))
> 
> 
> should the mount_setattr stuf be added in the related patch instead ?

Indeed, I will move to the mount_setattr patch.