[PATCH] Increase the timeout of locale/tst-localedef-path-norm

[Carlos O'Donell]

On 7/18/22 15:50, Adhemerval Zanella Netto via Libc-alpha wrote:
> 
> 
> On 18/07/22 10:42, Mark Wielaard via Libc-alpha wrote:
>> From: Mark Wielaard <mark@klomp.org>
>>
>> On the current AArch64 buildbot glibc-fedora-arm64
>> the 30s timeout is not enough to run this test, the
>> machine has 8 cores, but the testcase is deliberately
>> single threaded
>>
>>   make test t=locale/tst-localedef-path-norm
>>
>> takes about 45s, so I increased the timeout to 60s.
>>
>> This is the only failure on this buildbot builder.
>> https://builder.sourceware.org/buildbot/#/builders/glibc-fedora-arm64
>> ---
>>  locale/tst-localedef-path-norm.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/locale/tst-localedef-path-norm.c b/locale/tst-localedef-path-norm.c
>> index 68995a415..80e1c556d 100644
>> --- a/locale/tst-localedef-path-norm.c
>> +++ b/locale/tst-localedef-path-norm.c
>> @@ -236,5 +236,5 @@ do_test (void)
>>    return 0;
>>  }
>>  
>> -#define TIMEOUT 30
>> +#define TIMEOUT 60

A default timeout of 60s is too long. You need to increase TIMEOUTFACTOR if you
have a slow disk attached to the system under test.

>>  #include <support/test-driver.c>
> 
> I think it would be maybe better to either split the test, so we can
> improve make check parallel runtime; or use a large TIMEOUTFACTOR.

We could. There is a balance here because the tests need root and write to / to
exercise the path normalization code. My comment from 2020 explains this balance.

102   /* It takes ~10 seconds to serially execute 9 localedef test.  We
103      could run the compilations in parallel if we want to reduce test
104      time.  We don't want to split this out into distinct tests because
105      it would require multiple chroots.  Batching the same localedef
106      tests saves disk space during testing.  */

-- 
Cheers,
Carlos.