[PATCH v9 5/9] x86: Add SSE2 optimized chacha20

Noah Goldstein goldstein.w.n@gmail.com
Wed Jul 13 18:53:07 GMT 2022


On Wed, Jul 13, 2022 at 11:29 AM Adhemerval Zanella Netto
<adhemerval.zanella@linaro.org> wrote:
>
>
>
> On 13/07/22 15:27, Noah Goldstein wrote:
> >>>>> +
> >>>>
> >>>> If you have time make the ifunc changes to avx2 can you add:
> >>>>
> >>>> #include <isa-level.h>
> >>>> #if MINIMUM_X86_ISA_LEVEL <= 1
> >>>> <contentions of file>
> >>>> #endif
> >>>>
> >>>> as a build guard?
> >>>
> >>> Alright, I will add it.
> >
> > Err it should be
> > #if MINIMUM_X86_ISA_LEVEL <= 2
> >
> > sorry.
>
> I think it makes more sense to add the #if MINIMUM_X86_ISA_LEVEL <= 2 check
> on the AVX2 patch, since this patch isolated is required for all ISA levels.

Agreed. Good point.


More information about the Libc-alpha mailing list