[PATCH] posix: Replace posix_spawnattr_tc{get,set}pgrp_np with posix_spawn_file_actions_addtcsetpgrp_np

[Samuel Thibault]

Adhemerval Zanella, le jeu. 27 janv. 2022 15:09:29 -0300, a ecrit:
> 
> 
> On 27/01/2022 14:15, Samuel Thibault wrote:
> > Hello,
> > 
> > Adhemerval Zanella via Libc-alpha, le jeu. 27 janv. 2022 14:04:28 -0300, a ecrit:
> >> On 27/01/2022 13:11, Florian Weimer wrote:
> >>> * Adhemerval Zanella:
> >>>
> >>>> The posix_spawnattr_tcsetpgrp_np works on a file descriptor (the
> >>>> controlling terminal), so it would make more sense to actually fit
> >>>> it on the file actions API.
> >>>>
> >>>> Also, POSIX_SPAWN_TCSETPGROUP is not really required since it is
> >>>> implicit by the presence of tcsetpgrp file action.
> >>>>
> >>>> The posix/tst-spawn6.c is also fixed when TTY can is not present.
> >>>>
> >>>> Checked on x86_64-linux-gnu and i686-linux-gnu.
> >>>
> >>> This has an ABI check failure on Hurd:
> >>>
> >>> --- ../sysdeps/mach/hurd/i386/libc.abilist      2022-01-27 10:04:20.120812828 -0500
> >>> +++ /home/bmg/build/glibcs/i686-gnu/glibc/libc.symlist  2022-01-27 10:43:39.646804376 -0500
> >>> @@ -2292,2 +2291,0 @@ GLIBC_2.35 posix_spawn_file_actions_addt
> >>> -GLIBC_2.35 posix_spawnattr_tcgetpgrp_np F
> >>> -GLIBC_2.35 posix_spawnattr_tcsetpgrp_np F
> >>>
> >>> The changes look okay to me.  A second review is probably warranted at
> >>> this stage.
> >>
> >> Thanks.  It is really annoying that hurd make update-abi adds a bunch of files
> >> and requires manual edit to get it right.
> > 
> > I don't think I understand.  How is it different in the linux case?
> 
> A 'make update-abi' with a default 'configure --prefix=/usr' creates two
> files on source:
> 
> $ git status
> On branch master
> Your branch is up to date with 'origin/master'.
> 
> Changes not staged for commit:
>   (use "git add <file>..." to update what will be committed)
>   (use "git restore <file>..." to discard changes in working directory)
>         modified:   sysdeps/mach/hurd/i386/libc.abilist
>         modified:   sysdeps/mach/hurd/libhurduser.abilist
>         modified:   sysdeps/mach/libmachuser.abilist
> 
> And the libc.abilist is jsut annoying by the fact Hurd seems to use a different
> default path than Linux ports (which generates an _nl_default_dirname with
> different size).
> 
> Am I doing something wrong with the Hurd build?

Probably not, I didn't even know about the update-abi target.

Samuel