[PATCH v9 1/3] elf: Add a test for PT_LOAD segments with mixed p_align [BZ #28676]

Joseph Myers joseph@codesourcery.com
Mon Jan 24 21:21:50 GMT 2022


On Mon, 24 Jan 2022, Adhemerval Zanella via Libc-alpha wrote:

> > +# Make a copy of tst-p_alignmod-base.so and lower p_align of the first
> > +# PT_LOAD segment.
> > +$(objpfx)tst-p_alignmod1.so: $(objpfx)tst-p_alignmod1-edit \
> > +			     $(objpfx)tst-p_alignmod-base.so
> > +	rm -f $@
> > +	cp $(objpfx)tst-p_alignmod-base.so $@
> > +	$(test-wrapper-env) $(run-program-env) $(rtld-prefix) \
> > +	  $(objpfx)tst-p_alignmod1-edit $@

This has broken the testsuite build for all cross-compilation situations 
not running the newly built tests.  You can't run a program built with the 
new glibc unless $(run-built-tests) is yes.  Either disable everything 
depending on running these programs unless $(run-built-tests) is yes or 
revert the commits adding them (reimplementing the editing in Python using 
only the standard library might be a possibility for the future; building 
the C program for $build wouldn't be a good idea and we'd like to phase 
out the remaining two tests that do use C programs for $build by subsuming 
them in conformtest).

-- 
Joseph S. Myers
joseph@codesourcery.com


More information about the Libc-alpha mailing list