[PATCH v6] posix: Add terminal control setting support for posix_spawn

Florian Weimer fweimer@redhat.com
Thu Jan 13 15:03:19 GMT 2022


* Adhemerval Zanella via Libc-alpha:

> diff --git a/include/unistd.h b/include/unistd.h
> index 2bcdd494e1..6e71d80015 100644
> --- a/include/unistd.h
> +++ b/include/unistd.h
> @@ -183,6 +183,10 @@ extern int __truncate (const char *path, __off_t __length);
>  extern void *__sbrk (intptr_t __delta);
>  libc_hidden_proto (__sbrk)
>  
> +extern int __tcsetpgrp (int fd, __pid_t pgrp);
> +libc_hidden_proto (__tcsetpgrp)
> +extern pid_t __getpgrp (void);
> +libc_hidden_proto (__getpgrp);

Is __getpgrp used anywhere?

The patch seems to use __getpgid instead.

> +  /* Trying to set the controlling terminal after a setsid() incurs in a ENOTTY

No () after function name?

Thanks,
Florian



More information about the Libc-alpha mailing list