[PATCH v9 1/4] elf: Add la_activity during application exit

Jonathon Anderson janderson@rice.edu
Tue Jan 4 17:13:10 GMT 2022



On 1/3/22 07:25, Adhemerval Zanella wrote:
> +	  /* The cookie identifies the object at the head of the link map,
> +	     so we only add a new namespace if it changes from previous
> +	     one.  This work since dlmopen is the last in the test body.  */
Very minor nit: this comment seems to belong on the second conditional, 
rather than the first.
> +	  if (cookie != last_act_cookie && last_act_cookie != -1)
> +	    TEST_COMPARE (last_act, LA_ACT_CONSISTENT);
> +
> +	  if (this_act == LA_ACT_ADD && acts[nacts - 1] != cookie)
> +	    {
> +	      acts[nacts++] = cookie;
> +	      last_act_cookie = cookie;
> +	    }

Otherwise LGTM. Thanks for taking the time to work on this patch!

-Jonathon


More information about the Libc-alpha mailing list