[PATCH] benchtests: make compare_strings.py accept string as attribute value
Siddhesh Poyarekar
siddhesh@gotplt.org
Fri Feb 25 09:15:52 GMT 2022
On 25/02/2022 14:28, Su Lifan via Libc-alpha wrote:
> Commit ac759b1fbf28a82d99afde9046f8b72c7cba5dae added attribute
> "overlap" to bench-memmove-walk, whose value is a string. This change
> makes compare_strings.py fail since benchout_strings.schema.json
> requires the values of attributes to be number.
>
> This patch relaxes such constraint.
LGTM.
Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
> ---
> benchtests/scripts/benchout_strings.schema.json | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/benchtests/scripts/benchout_strings.schema.json
> b/benchtests/scripts/benchout_strings.schema.json
> index 7c9a67134b..bfd9b4e6c0 100644
> --- a/benchtests/scripts/benchout_strings.schema.json
> +++ b/benchtests/scripts/benchout_strings.schema.json
> @@ -28,7 +28,12 @@
> "items": {"type": "number"}
> }
> },
> - "additionalProperties": {"type": "number"},
> + "additionalProperties": {
> + "oneOf": [
> + { "type": "number" },
> + { "type": "string" }
> + ]
> + },
> "minProperties": 2
> }
> }
> --
> 2.32.0
>
More information about the Libc-alpha
mailing list