[PATCH] microblaze: Use the correct select syscall (BZ #28883)

[Adhemerval Zanella]

On 16/02/2022 12:48, Mark Hatle wrote:
> The other option would be to remove the non-__assume_pselect path, and simply require all systems to have pselect.  (This would require microblaze to move to kernel 3.15 minimum, which may be reasonable behavior.)
> 
> (It has been a long time since Xilinx has shipped a kernel older then 3.15, so it would be down to specific users trying to hold onto an older kernel.)

I don't have a strong preference, we usually tie the minimum kernel version to
the LTS support one for the architecture.  Also, bumping the minimum kernel
version is usually done when there is room for code cleanups (which seems
minimal for this case).

> 
> --Mark
> 
> On 2/16/22 9:15 AM, Andreas Schwab wrote:
>> On Feb 16 2022, Adhemerval Zanella via Libc-alpha wrote:
>>
>>> On Microblaze only __NR_newselect is implemented, even though kernel
>>> advertise __NR_select on asm/unistd.h.  Instead of adding an ad-hoc
>>> logic on select.c, change the __NR_select of microblaze by overwritting
>>> with fixup-asm-unistd.h.
>>
>> Microblaze is the only architecture that undefines __ASSUME_PSELECT (for
>> very old kernels), so it is the only one to actually trigger that
>> fallback in select.c.  I think that fallback could just be changed to
>> use _newselect instead.
>>