[PATCH] resolv: Do not build libanl.so for ABIs starting at 2.35
Florian Weimer
fweimer@redhat.com
Fri Feb 11 11:42:59 GMT 2022
* Stafford Horne:
> One more thing, sorry I just picked this up now. After the fixes we are now
> getting:
>
> make: Entering directory '/home/shorne/work/gnu-toolchain/glibc/resolv'
> make: *** No rule to make target '/home/shorne/work/gnu-toolchain/build-glibc/resolv/tst-resolv-res_ninit.out', needed by '/home/shorne/work/gnu-toolchain/build-glibc/resolv/mtrace-tst-resolv-res_ninit.out'. Stop.
> make: Leaving directory '/home/shorne/work/gnu-toolchain/glibc/resolv'
>
> The "if" condition change blocked many of the tst-resolv* tests from being
> built or run for 2.35 only ports. Is that expected? There are now a few
> things like above that are missing their dependencies. Do we need:
>
> diff --git a/resolv/Makefile b/resolv/Makefile
> index c465479e8b..11e3b203a3 100644
> --- a/resolv/Makefile
> +++ b/resolv/Makefile
> @@ -84,7 +84,9 @@ endif
> ifeq ($(have-GLIBC_2.34)$(have-thread-library),yesyes)
> # Empty compatibility library for old binaries.
> extra-libs += libanl
> +endif
>
> +ifeq ($(have-thread-library),yes)
> tests += \
> tst-bug18665 \
> tst-bug18665-tcp \
Sorry about that, I should have reviewed this more closely.
Can you move the libanl settings closer together?
$(libanl-routines-var) should be outside the $(have-GLIBC_2.34)
condition, libanl-routines += libanl-compat should be inside it.
Thanks,
Florian
More information about the Libc-alpha
mailing list