[PATCH v2 5/5] Linux: Consolidate auxiliary vector parsing

Florian Weimer fweimer@redhat.com
Thu Feb 10 11:31:40 GMT 2022


* Adhemerval Zanella:

>> The GCC error message doesn't suggest a strong preference either way:
>> 
>> /tmp/t.c:1:1: error: static assertion failed: "failed"
>>     1 | _Static_assert (0, "failed");
>>       | ^~~~~~~~~~~~~~
>> 
>> I think in the existing sources, the message is sometimes indicating the
>> failure, or what is being asserted (as is the case here).
>
> Compiler is will just emit the message if condition is met, my point is
> emitting 'CONSTANT_MINSIGSTKSZ is constant' on an error is the opposite
> of what triggered it (CONSTANT_MINSIGSTKSZ is really *not* a constant).

But the check asserts that CONSTANT_MINSIGSTKSZ is constant, so the
message is still correct.

Thanks,
Florian



More information about the Libc-alpha mailing list