[PATCH v3] hppa: Fix bind-now audit (BZ #28857)

John David Anglin dave.anglin@bell.net
Mon Feb 7 17:13:07 GMT 2022


On 2022-02-07 10:46 a.m., Andreas Schwab wrote:
> On Feb 07 2022, Adhemerval Zanella via Libc-alpha wrote:
>
>> +/* Clear the plabel bit to get the actual address of the descriptor.  */
>> +#define DL_FIXUP_ADDR_VALUE(addr) \
>> +  (*(DL_FIXUP_VALUE_TYPE *) ((unsigned int) (addr) & ~2))
> Why not uintptr_t?
>
>> +#define DL_FIXUP_BINDNOW_RELOC(value, new_value, st_value)	\
>> +  *(value) = *(DL_FIXUP_VALUE_TYPE *) ((unsigned int) (new_value) & ~2);
> Likewise.  Why is there a semicolon?
Good suggestions.

-- 
John David Anglin  dave.anglin@bell.net



More information about the Libc-alpha mailing list