[PATCH v1] Benchtests: Add length zero benchmark for memset in bench-memset.c

H.J. Lu hjl.tools@gmail.com
Sun Feb 6 16:22:42 GMT 2022


On Sat, Feb 5, 2022 at 9:51 PM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
>
> Zero is a relevant size for some workloads (roughly 5% of uses for
> GCC) so we should be testing it's performance as well.
> ---
>  benchtests/bench-memset.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/benchtests/bench-memset.c b/benchtests/bench-memset.c
> index beba3fbe46..6f5b3d04a6 100644
> --- a/benchtests/bench-memset.c
> +++ b/benchtests/bench-memset.c
> @@ -110,7 +110,7 @@ test_main (void)
>      {
>        for (i = 0; i < 18; ++i)
>         do_test (&json_ctx, 0, c, 1 << i);
> -      for (i = 1; i < 64; ++i)
> +      for (i = 0; i < 64; ++i)
>         {
>           do_test (&json_ctx, i, c, i);
>           do_test (&json_ctx, 4096 - i, c, i);
> --
> 2.25.1
>

LGTM.

Reviewed-by: H.J. Lu <hjl.tools@gmail.com>

Thanks.

-- 
H.J.


More information about the Libc-alpha mailing list