[PATCH v1] Benchtests: move 'alloc_bufs' from loop in bench-memset.c

Noah Goldstein goldstein.w.n@gmail.com
Sat Feb 5 22:58:44 GMT 2022


On Sat, Feb 5, 2022 at 11:29 AM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> On Sat, Feb 5, 2022 at 1:10 AM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
> >
> > One buf allocation is sufficient. Calling `alloc_bufs' in the loop
> > just adds unnecessary syscall overhead.
> > ---
> >  benchtests/bench-memset.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/benchtests/bench-memset.c b/benchtests/bench-memset.c
> > index beba3fbe46..e1e2d5f176 100644
> > --- a/benchtests/bench-memset.c
> > +++ b/benchtests/bench-memset.c
> > @@ -74,7 +74,6 @@ do_test (json_ctx_t *json_ctx, size_t align, int c, size_t len)
> >    FOR_EACH_IMPL (impl, 0)
> >      {
> >        do_one_test (json_ctx, impl, (CHAR *) (buf1) + align, c, len);
> > -      alloc_bufs ();
> >      }
> >
> >    json_array_end (json_ctx);
> > @@ -88,8 +87,9 @@ test_main (void)
> >    size_t i;
> >    int c = 0;
> >
> > -  test_init ();
> >
> > +  test_init ();
> > +  alloc_bufs ();
> >    json_init (&json_ctx, 0, stdout);
> >
> >    json_document_begin (&json_ctx);
> > --
> > 2.25.1
> >
>
> LGTM.
>
> Reviewed-by: H.J. Lu <hjl.tools@gmail.com>
>
> Thanks.

Thanks pushed.
>
> --
> H.J.


More information about the Libc-alpha mailing list