[PATCH 01/15] linux: Add pidfd_open

Adhemerval Zanella adhemerval.zanella@linaro.org
Fri Feb 4 19:59:30 GMT 2022



On 04/02/2022 16:46, Joseph Myers wrote:
> On Thu, 3 Feb 2022, Adhemerval Zanella via Libc-alpha wrote:
> 
>> +    sys.exit(glibcextract.compare_macro_consts(
>> +                '#include <sys/pidfd.h>\n',
>> +                '#include <asm/fcntl.h>\n'
>> +                '#include <linux/pidfd.h>\n',
>> +                args.cc,
>> +                'PIDFD_.*'))
> 
> Are you sure about doing this sort of comparison without the kind of 
> kernel version checks done in tst-mman-consts.py?  That's only OK if (a) 
> all the compared macros are present in the oldest kernel headers version 
> supported for building glibc and (b) no matching macros will be added in 
> any future kernel version.
> 

Right, I think it would be good to add such check since neither (a) or
(b) might hold true.


More information about the Libc-alpha mailing list