[PATCH v5 05/11] stdio-common: Convert vfprintf and related functions to buffers

[Florian Weimer]

* Adhemerval Zanella Netto:

> Patch looks good, there is only a small nit on the libio vtable removal
> that in turn showed an issue on elf/tst-relro-symbols.py.
>
> LGTM, thanks.
>
> Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>

Thanks.

>> -const struct _IO_jump_t _IO_strn_jumps libio_vtable attribute_hidden =
>
> We need to remove both _IO_strn_jumps definition from libio/strfile.h and
> from tst-relro-libc.out.

Yes, fixed.

>> -#ifdef COMPILE_WPRINTF
>> -static const struct _IO_jump_t _IO_helper_jumps libio_vtable =
>> -{

>> -#else
>> -static const struct _IO_jump_t _IO_helper_jumps libio_vtable =
>> -{

> The _IO_helper_jumps should be removed from tst-relro-symbols.py
> required list, and tst-relro-symbols.py not showing a regression
> raised some questions.  It turned out that it is not really testing
> the required symbols due a bug, with the fix below:

Right, thanks.

Florian