[PATCH] syslog: Fix large messages (BZ#29536)

[Siddhesh Poyarekar]

On 2022-08-29 16:19, Adhemerval Zanella Netto wrote:
> 
> 
> On 29/08/22 17:16, Siddhesh Poyarekar wrote:
>> On 2022-08-29 08:37, Adhemerval Zanella via Libc-alpha wrote:
>>> The a583b6add407c17cd change did not handle large messages that
>>> would require a heap allocation correctly, where the message itself
>>> is not take in consideration.
>>>
>>> This patch fixes it and extend the tst-syslog to check for large
>>> messages as well.
>>>
>>> Checked on x86_64-linux-gnu.
>>
>> The change itself looks good.  For the test, could it cover both large as well as small strings?  e.g., 64, 1024 and 1280 byte messages. That'll ensure all code paths are covered.
> 
> It already does for small messages that would use the static buffer, do you
> think we need to exercise another size (the code path will be identical
> to current coverage)?
> 

Ahh sorry I misread the diff.  LGTM.

Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>