[PATCH] Linux: Fix enum fsconfig_command detection in <sys/mount.h>

Florian Weimer fweimer@redhat.com
Tue Aug 16 09:51:10 GMT 2022


* Andreas Schwab:

> On Aug 16 2022, Florian Weimer via Libc-alpha wrote:
>
>> The #ifdef FSOPEN_CLOEXEC check did not work because the macro
>> was defined prior to its use.
>
> This is confusing, since generally we want macros to be defined before
> their use.  What's important here is that the use is about checking for
> absence of the macro in the kernel header.

Do you suggest to reword the commit message?  What about this?

“
The #ifdef FSOPEN_CLOEXEC check did not work because the macro
was always defined in this header prior to the check, so that
the <linux/mount.h> contents did not matter.
”

Thanks,
Florian



More information about the Libc-alpha mailing list