[PATCH v1] x86: Fix `#define STRCPY` guard in strcpy-sse2.S
H.J. Lu
hjl.tools@gmail.com
Mon Aug 8 14:21:57 GMT 2022
On Sun, Aug 7, 2022 at 8:26 PM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
>
> `#ifndef STPCPY` is incorrect for checking if `STRCPY` is already
> defined. It doesn't end up mattering as the whole check is
> guarded by `#if IS_IN (libc)` but is incorrect none the less.
> ---
> sysdeps/x86_64/multiarch/strcpy-sse2.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sysdeps/x86_64/multiarch/strcpy-sse2.S b/sysdeps/x86_64/multiarch/strcpy-sse2.S
> index e29b411314..d6b9bae5f8 100644
> --- a/sysdeps/x86_64/multiarch/strcpy-sse2.S
> +++ b/sysdeps/x86_64/multiarch/strcpy-sse2.S
> @@ -22,7 +22,7 @@
>
> # include <sysdep.h>
>
> -# ifndef STPCPY
> +# ifndef STRCPY
> # define STRCPY __strcpy_sse2
> # endif
>
> --
> 2.34.1
>
LGTM.
Thanks.
--
H.J.
More information about the Libc-alpha
mailing list