[PATCH] i386: Use cmpl instead of cmp
H.J. Lu
hjl.tools@gmail.com
Thu Aug 4 21:25:08 GMT 2022
On Thu, Aug 4, 2022 at 2:00 PM Adhemerval Zanella
<adhemerval.zanella@linaro.org> wrote:
>
> Clang cannot assemble cmp in the AT&T dialect mode.
> ---
> sysdeps/i386/i686/multiarch/wcscpy-ssse3.S | 8 ++++----
> sysdeps/i386/i686/multiarch/wcslen-sse2.S | 16 ++++++++--------
> 2 files changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/sysdeps/i386/i686/multiarch/wcscpy-ssse3.S b/sysdeps/i386/i686/multiarch/wcscpy-ssse3.S
> index 601e0f0138..fa6598c54d 100644
> --- a/sysdeps/i386/i686/multiarch/wcscpy-ssse3.S
> +++ b/sysdeps/i386/i686/multiarch/wcscpy-ssse3.S
> @@ -41,13 +41,13 @@ ENTRY (__wcscpy_ssse3)
> mov STR1(%esp), %edx
> mov STR2(%esp), %ecx
>
> - cmp $0, (%ecx)
> + cmpl $0, (%ecx)
> jz L(ExitTail4)
> - cmp $0, 4(%ecx)
> + cmpl $0, 4(%ecx)
> jz L(ExitTail8)
> - cmp $0, 8(%ecx)
> + cmpl $0, 8(%ecx)
> jz L(ExitTail12)
> - cmp $0, 12(%ecx)
> + cmpl $0, 12(%ecx)
> jz L(ExitTail16)
>
> PUSH (%edi)
> diff --git a/sysdeps/i386/i686/multiarch/wcslen-sse2.S b/sysdeps/i386/i686/multiarch/wcslen-sse2.S
> index 5337286d41..d49a7ce355 100644
> --- a/sysdeps/i386/i686/multiarch/wcslen-sse2.S
> +++ b/sysdeps/i386/i686/multiarch/wcslen-sse2.S
> @@ -24,21 +24,21 @@
> ENTRY (__wcslen_sse2)
> mov STR(%esp), %edx
>
> - cmp $0, (%edx)
> + cmpl $0, (%edx)
> jz L(exit_tail0)
> - cmp $0, 4(%edx)
> + cmpl $0, 4(%edx)
> jz L(exit_tail1)
> - cmp $0, 8(%edx)
> + cmpl $0, 8(%edx)
> jz L(exit_tail2)
> - cmp $0, 12(%edx)
> + cmpl $0, 12(%edx)
> jz L(exit_tail3)
> - cmp $0, 16(%edx)
> + cmpl $0, 16(%edx)
> jz L(exit_tail4)
> - cmp $0, 20(%edx)
> + cmpl $0, 20(%edx)
> jz L(exit_tail5)
> - cmp $0, 24(%edx)
> + cmpl $0, 24(%edx)
> jz L(exit_tail6)
> - cmp $0, 28(%edx)
> + cmpl $0, 28(%edx)
> jz L(exit_tail7)
>
> pxor %xmm0, %xmm0
> --
> 2.34.1
LGTM.
Thanks.
--
H.J.
More information about the Libc-alpha
mailing list