[PATCH] malloc: Correct the documentation of the top_pad default

Florian Weimer fweimer@redhat.com
Thu Aug 4 15:14:16 GMT 2022


* Siddhesh Poyarekar:

> On 2022-08-04 04:48, Florian Weimer via Libc-alpha wrote:
>> DEFAULT_TOP_PAD is defined as 131072 in
>> sysdeps/generic/malloc-machine.h.
>
> LGTM, but I wonder if we should tighten this so that it doesn't appear
> that DEFAULT_TOP_PAD could be 0 in any of our build configurations. 
> e.g. we could replace the definition with a #error "define
> DEFAULT_TOP_PAD" or something like that to ensure that it's always 
> defined through malloc-machine.h.  What do you think?

We could just remove the various #ifdefs, I guess.  The other question
is whether we can use the constant in the tunable definition file.  I
haven't investigate any of this.

Should I push my change in the meantime?

Thanks,
Florian



More information about the Libc-alpha mailing list