[PATCH v3 2/2] nptl: Fix race between pthread_kill and thread exit (bug 12889)

Florian Weimer fweimer@redhat.com
Fri Sep 10 15:19:35 GMT 2021


* Adhemerval Zanella:

> On 06/09/2021 09:34, Florian Weimer via Libc-alpha wrote:
>> A new thread exit lock and flag are introduced.  They are used to
>> detect that the thread is about to exit or has exited in
>> __pthread_kill_internal, and the signal is not sent in this case.
>> 
>> The test sysdeps/pthread/tst-pthread_cancel-select-loop.c is derived
>> from a downstream test originally written by Marek Polacek.
>
> LGTM, with just a suggestion to use C11 atomics instead of atomic
> builtins on the tests.

I prefer the __atomic built-ins because we have free documentation for
them.  Still okay to use them?

Thanks,
Florian



More information about the Libc-alpha mailing list