[PATCH v8 3/3] String: Add tests for __memcmpeq

[Noah Goldstein]

On Thu, Oct 21, 2021 at 7:42 PM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> On Thu, Oct 21, 2021 at 4:47 PM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
> >
> > On Thu, Oct 21, 2021 at 5:58 PM H.J. Lu <hjl.tools@gmail.com> wrote:
> > >
> > > On Thu, Oct 21, 2021 at 3:40 PM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
> > > >
> > > > No bug.
> > > >
> > > > This commit adds tests for the new function __memcmpeq. The new tests
> > > > use the existing tests in 'test-memcmp.c' but relax the result
> > > > requirement to only check for zero or non-zero returns.
> > > >
> > > > All string tests include test-memcmpeq are passing.
> > > > ---
> > > > Note at the momement for test-memcmpeq.c the
> > > > tests only appear to do the generic versions.
> > > >
> > > > For example on x86_64 the output of test-memcmpeq.out is:
> > > >
> > > >
> > > > ```
> > > >                         __memcmpeq simple_memcmp
> > > > ```
> > > >
> > > > whereas test-memcmp.out is:
> > > >
> > > > ```
> > > >                         simple_memcmp __memcmp_avx2_movbe
> > > > __memcmp_evex_movbe __memcmp_sse4_1 __memcmp_ssse3 __memcmp_sse2
> > > > ```
> > > >
> > > > So the test is not going through all available ifuncs. I'm not
> > > > sure if this is expected or indicates a bug in the previous
> > > > patches adding support for __memcmpeq.
> > > >
> > >
> > > This doesn't look right.  If __memcmpeq is a true alias of memcmp, you
> > > should only have simple_memcmpeq and __memcmpeq.
> >
> > Figured. Any idea what the issue might be?
>
> Where is your branch?  I can take a look.

Made a new branch on your gitlab here:

https://gitlab.com/x86-glibc/glibc/-/tree/users/goldsteinn/memcmpeq-abi

>
> --
> H.J.