[PATCH v8 2/3] String: Add hidden defs for __memcmpeq() to enable internal usage

Joseph Myers joseph@codesourcery.com
Fri Oct 22 00:18:10 GMT 2021


On Thu, 21 Oct 2021, Noah Goldstein via Libc-alpha wrote:

> I have gone through all non-test .c files in GLIBC and replaced memcmp
> with __memcmpeq where it makes sense. I can post that as a separate
> patchset and we can decide whether it's a good idea there.

I think it's a bad idea - it obfuscates the source code and it's better 
just to call the standard function, leave the code more readable and let 
the compiler optimize it as appropriate.

-- 
Joseph S. Myers
joseph@codesourcery.com


More information about the Libc-alpha mailing list