Monday Patch Queue Review update (2021-11-29)
Adhemerval Zanella
adhemerval.zanella@linaro.org
Tue Nov 30 16:31:21 GMT 2021
On 30/11/2021 13:19, Florian Weimer wrote:
> * Adhemerval Zanella via Libc-alpha:
>
>>> * Doesn't apply. Does it need a patch before this?
>>> * linux: Use /proc/stat fallback for __get_nprocs_conf (BZ #28624)
>>> * Florian to provide additional feedback about simplification.
>>
>> I think Florian remarks are in fact a different issue, where we assume sysfs
>> support (the issue was in fact a patch of mine removed too much).
>
> I think we should have changed
>
> return 1;
>
> to
>
> return 2;
>
> in __get_nprocs, and not to:
>
> return get_nproc_stat (buffer, buffer_size);
>
> It would have fixed the reported issue because we would keep
> conservatively reporting SMP support.
But it is doing exactly this right now, since get_nproc_stat will
return 2 if /proc can not be opened.
More information about the Libc-alpha
mailing list